Implement named backreferences #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Hmm, removing |
|
@swift-ci please test macOS |
|
looks like a CI glitch! |
milseman
approved these changes
May 25, 2022
| @@ -38,13 +38,24 @@ extension MEProgram where Input.Element: Hashable { | |||
| // Special addresses or instructions | |||
| var failAddressToken: AddressToken? = nil | |||
|
|
|||
| var captureList = CaptureList() | |||
| private(set) var namedCaptureOffsets: [String: Int] = [:] | |||
There was a problem hiding this comment.
Could we just fully drop the dictionary? If there are fewer than 2^4-ish named captures I'd expect linear search to be better anyways. It seems like CaptureList could just have an API for this
There was a problem hiding this comment.
Makes sense, how does this look?
Use the CaptureList as the source of truth on which index a name corresponds to, and query it when emitting a named backreference.
This doesn't appear to be used, and should be available from the CaptureList.
hamishknight
force-pushed
the
named-refs
branch
2 times, most recently
from
a9fcc86 to
4b7d534
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the CaptureList as the source of truth on which index a name corresponds to, and query it when emitting a named backreference.
Resolves #388