Skip to content

Make RegexCompilationError internal #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented May 26, 2022

RegexCompilationError was not meant to be exposed as API.

`RegexCompilationError` was not meant to be exposed as API.
@rxwei rxwei requested a review from natecook1000 May 26, 2022 01:49
@rxwei
Copy link
Contributor Author

rxwei commented May 26, 2022

@swift-ci please test

Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rxwei rxwei merged commit a936e9e into swiftlang:main May 26, 2022
@rxwei rxwei deleted the internal-regex-compilation-error branch May 26, 2022 17:05
@hamishknight
Copy link
Contributor

@rxwei FYI I opened a 5.7 cherry-pick #459

@rxwei
Copy link
Contributor Author

rxwei commented May 30, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants