Additional character property parsing #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only supported a subset of the Oniguruma spellings for these. Introduce them as an actual Unicode property with the key `blk` or `block`. Additionally, allow a non-Unicode shorthand syntax that uses the prefix `in`. This is supported by Oniguruma and Perl (though Perl discourages its usage). We may want to warn/error on it and suggest users switch to the more explicit form.
These correspond to various `is`-prefixed accessors on `java.lang.Character`. For now, parse them, but mark them unsupported.
|
@swift-ci please test |
natecook1000
approved these changes
May 27, 2022
There was a problem hiding this comment.
LGTM, we can implement the java special property support, but we'll need the block Unicode data to implement those (cc @Azoy).
| parseTest(#"\p{inherited}"#, prop(.scriptExtension(.inherited))) | ||
|
|
||
| // Make sure these are round-trippable. | ||
| for s in Unicode.Script.allCases { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formalize the parsing of Unicode block properties (previously they were the remaining Oniguruma special properties), including allowing the shorthand spelling e.g
\p{inBasicLatin}, which is supported by Perl and Oniguruma (though Perl discourages it).Additionally, start parsing the Java character properties.