[5.7] Some trivia fixes #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this to replace the various places we're doing `var src = self`.
We don't have to handle bailing early, the loop will terminate if we don't lex another operator.
Make sure an inverted character class does not dump the same as a regular character class.
`expectQuoted` expects non-empty contents, which doesn't apply to comments.
PCRE does not allow whitespace here, instead treating the sequence as literal if whitespace is present. However this behavior is quite unintuitive. Instead, lex whitespace between range operands.
Previously we would only parse non-semantic whitespace, but also expand to end-of-line comments, which are supported by ICU.
Factor out the logic that deals with parsing an individual character class member, and interleave `lexTrivia` calls between range operand parsing.
|
@swift-ci please test |
stephentyrone
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.7 cherry-pick of #431
x{2, 3}. This differs from PCRE, which would treat such a sequence as literal, but it's more intuitive to allow whitespace.