Use inits instead of as methods #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
| /// Use this initializer to create a strongly typed regex from | ||
| /// one that was created from a string. Returns `nil` if the types | ||
| /// don't match. | ||
| public init?(_ dynamic: Regex<AnyRegexOutput>) { |
There was a problem hiding this comment.
It feels like we should have an as: Output.Type = Output.self parameter to match the run-time string-based initializer. e.g.
let pattern = "a+(b+)c+"
let a = try Regex(pattern, as: (Substring, Substring).self))
let b: Regex<(Substring, Substring)> = try Regex(pattern)
let dynamic = try Regex(pattern)
let c = Regex(dynamic, as: (Substring, Substring).self)!
let d: Regex<(Substring, Substring)> = Regex(dynamic)!There was a problem hiding this comment.
Argh that syntax highlighting. Any ideas for a better argument name than dynamic?
|
@swift-ci please test |
milseman
added a commit
to milseman/swift-experimental-string-processing
that referenced
this pull request
May 31, 2022
Use inits instead of as methods Add ARO tests
milseman
added a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.