Skip to content

Add additional capture transform tests. #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Jun 7, 2022

  • Add a test where the capture transform produecs a Substring from a Substring.
  • Add a test where the capture transform wraps a Substring in an Optional.

- Add a test where the capture transform produecs a `Substring` from a `Substring`.
- Add a test where the capture transform wraps a `Substring` in an `Optional`.
@rxwei rxwei requested a review from milseman June 7, 2022 20:28
@rxwei
Copy link
Contributor Author

rxwei commented Jun 7, 2022

From #469:

Similarly for when that capture-transform appears inside an Optionally or is adding or removing a layer of Substring optionality.

In this patch, it's impossible to write a test that removes a layer of Substring optionality because we don't have #470 yet. That is, a capture transform can only take a Substring today. I'll test this in that PR.

@rxwei
Copy link
Contributor Author

rxwei commented Jun 7, 2022

@swift-ci please test

@rxwei rxwei merged commit 18f2d61 into swiftlang:main Jun 13, 2022
@rxwei rxwei deleted the test-267 branch June 13, 2022 22:27
natecook1000 pushed a commit to natecook1000/swift-experimental-string-processing that referenced this pull request Jun 17, 2022
Add additional capture transform tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant