Allow scoped removal of extended syntax in multi-line literals #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
commented
Jun 15, 2022
milseman
reviewed
Jun 16, 2022
hamishknight
force-pushed
the
limited-run-syntax
branch
from
dd38d67 to
72adeba
Compare
This shouldn't include e.g `namedCapturesOnly`.
This should always be set in a multi-line literal, with extended syntax potentially being set and unset as we parse.
Relax the ban on unsetting extended syntax in a multi-line literal such that it does not apply to a scoped unset e.g `(?-x:...)`, as long as it does not span multiple lines. This commit also bans the use of `(?^)` in a multi-line literal, unless it is scoped and does not span multiple lines. Instead, `(?^x)` must be written, as PCRE defines `(?^)` to be equivalent to `(?-imnsx)`.
hamishknight
force-pushed
the
limited-run-syntax
branch
from
72adeba to
2aa035e
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the ban on unsetting extended syntax in a multi-line literal such that it does not apply to a scoped unset e.g
(?-x:...), as long as it does not span multiple lines.This PR also bans the use of
(?^)in a multi-line literal, unless it is scoped and does not span multiple lines. Instead,(?^x)must be written, as PCRE defines(?^)to be equivalent to(?-imnsx).