Skip to content

Add tests for substring / anchor interaction #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

natecook1000
Copy link
Member

^ and $ should match the start and end of the callee, even if that callee is a substring. Right now ^ and $ match the start and end of the callee's base string, instead. In addition, ^ and $ should only match the start and end of the callee when replacing a subrange, not the start and end of the subrange.

^ and $ should match the start and end of the callee, even if that
callee is a substring. Right now ^ and $ match the start and end of
the callee's base string, instead. In addition, ^ and $ should only
match the start and end of the callee when replacing a subrange, not
the start and end of the subrange.
@natecook1000 natecook1000 requested a review from milseman June 15, 2022 22:14
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit 55ffc5c into swiftlang:main Jun 16, 2022
milseman pushed a commit to milseman/swift-experimental-string-processing that referenced this pull request Jun 30, 2022
^ and $ should match the start and end of the callee, even if that
callee is a substring. Right now ^ and $ match the start and end of
the callee's base string, instead. In addition, ^ and $ should only
match the start and end of the callee when replacing a subrange, not
the start and end of the subrange.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants