Fix duplicate symbols static-linking failure by renaming symbols #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_swift_stdlib_XX symbols defined in _CUnicode module are also defined in runtime library as hidden visibility. It works in linking as a shared library, but it doesn't when statically linking with lld, which resolves lib_StringProcessing.a's _swift_stdlib_getScript and loads UnicodeScalarProps.c.o, then loads libswiftCore.a's UnicodeScalarProps.cpp.o for other _swift_stdlib_XX symbols that are not defined in UnicodeScalarProps.c.o.
This was referenced Jun 18, 2022
|
@Azoy can you look at this? |
|
@swift-ci please test |
|
Thanks! |
kateinoigakukun
added a commit
to swiftwasm/swift
that referenced
this pull request
Nov 3, 2022
Ideally, swiftlang/swift-experimental-string-processing#500 should be ported to 5.7 branch, but we don't control it, so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_swift_stdlib_XXsymbols defined in_CUnicodemodule are also defined in runtime library as hidden visibility.It works in linking as a shared library, but it doesn't when statically linking with lld, which resolves
lib_StringProcessing.a's_swift_stdlib_getScriptand loadsUnicodeScalarProps.c.o, then loadslibswiftCore.a'sUnicodeScalarProps.cpp.ofor other _swift_stdlib_XX symbols that are not defined in UnicodeScalarProps.c.o.This patch tries to fix the failure by renaming those symbols in _CUnicode module.
XFAILing test has been added by swiftlang/swift#59556, and will be un-XFAILed by swiftlang/swift#59562