Skip to content

De-genericize processor, engine, etc. #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2022
Merged

De-genericize processor, engine, etc. #502

merged 2 commits into from
Jun 21, 2022

Conversation

milseman
Copy link
Member

Provides only modest performance improvements (it was already getting specialized), but makes it possible to add String-specific specializations.

@milseman milseman requested a review from natecook1000 June 20, 2022 00:33
@milseman
Copy link
Member Author

Based on top of #501

@milseman
Copy link
Member Author

@swift-ci please test

@rctcwyvrn
Copy link
Contributor

The comparer in #505 seems to show more than just modest improvements!

=== Improvements ====================================================
- emailLookaheadNoMatchesFirst		88.4ms	92.1ms	-3.72ms	-4.0%
- emailRFCNoMatchesAll			109ms	115ms	-6.05ms	-5.0%
- emailLookaheadNoMatchesAll		88.4ms	92ms	-3.66ms	-4.0%
- ReluctantQuantWhole			14.2ms	17ms	-2.78ms	-16.0%
- emailRFCAll				54.6ms	116ms	-61.7ms	-53.0%
- notFoundFirst				15.3ms	17.6ms	-2.28ms	-13.0%
- EagarQuantWithTerminalWhole		6.63ms	7.94ms	-1.31ms	-16.0%
- emailLookaheadAll			103ms	215ms	-112ms	-52.0%
- htmlAll				14ms	37.6ms	-23.6ms	-63.0%
- cssAll				5.36ms	15ms	-9.63ms	-64.0%
- HangulSyllableAll			8.55ms	15ms	-6.4ms	-43.0%
- GraphemeBreakNoCapAll			10.1ms	22.2ms	-12.1ms	-55.0%
- emailRFCNoMatchesFirst		109ms	115ms	-6.05ms	-5.0%
- notFoundAll				15.3ms	17.6ms	-2.32ms	-13.0%

milseman added 2 commits June 20, 2022 19:19
@milseman
Avoid double execution by avoiding Array init
8c151e0
@milseman
De-genericize processor, engine, etc.
8c9ca19 
Provides only modest performance improvements (it was already getting
specialized), but makes it possible to add String-specific specializations.
@milseman
Copy link
Member Author

@swift-ci please test

natecook1000
natecook1000 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milseman milseman merged commit 94f5d33 into swiftlang:main Jun 21, 2022
@milseman milseman deleted the degenericize branch June 21, 2022 13:37
milseman added a commit to milseman/swift-experimental-string-processing that referenced this pull request Jun 30, 2022
@milseman
De-genericize processor, engine, etc. (swiftlang#502)
d2fae4b 
* Avoid double execution by avoiding Array init

* De-genericize processor, engine, etc.

Provides only modest performance improvements (it was already getting
specialized), but makes it possible to add String-specific specializations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 natecook1000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milseman @rctcwyvrn @natecook1000