Add new benchmarks and benchmarker functionality (try 2) #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erimental-string-processing into more_more_benchmarks
|
@swift-ci test |
|
@swift-ci test |
milseman
approved these changes
Jun 21, 2022
| @@ -0,0 +1,61 @@ | |||
| # python3 createBenchmark.py MyRegexBenchmark | |||
There was a problem hiding this comment.
If the benchmarks just added themselves to an array, would that simplify the registration process?
|
@swift-ci test |
rctcwyvrn
added a commit
to rctcwyvrn/swift-experimental-string-processing
that referenced
this pull request
Jun 30, 2022
- Adds benchmarks for html and email regexes - Adds support to save and compare benchmarker runs Co-authored-by: Michael Ilseman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes since the last PR
UseIt turns out that doesn't exist on corelibs-foundation either. It turns out the entireISO8601FormatStyleto fix the linux build failureformatfunction is missing so work around it with some#ifcreateBenchmark.pyutil script to create benchmarks + register them. After looking around at swift-collection-benchmark and the main swift repo's benchmarks, this seems to be the best way of doing things