Skip to content

Make the output of benchmark compares nicer #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

Make the output of benchmark compares nicer #512

merged 1 commit into from
Jun 23, 2022

Conversation

rctcwyvrn
Copy link
Contributor

@rctcwyvrn rctcwyvrn commented Jun 22, 2022 •
edited
Loading

  • Space out the names properly instead of relying on tabs
  • Add a decimal point to the percentage
  • Filter out NS benchmarks from the comparison (since they should never improve/regress, but they still show up due to our machines being inconsistent)
  • Sort comparisons by amount of improvement/regression (by s, not % beceause we have lots of variance + low runtime benchmarks)

@rctcwyvrn
Make the output of --compare nicer
adac89f 
- Space out the names properly instead of relying on tabs
- Add a decimal point to the percentage
- Filter out NS benchmarks from the comparison
- Sort comparisons by amount of improvement/regression
  (by s, not % beceause we have lots of variance + low runtime benchmarks)
@rctcwyvrn
Copy link
Contributor Author

@swift-ci test

@rctcwyvrn rctcwyvrn requested a review from milseman June 22, 2022 23:28
@rctcwyvrn rctcwyvrn merged commit 8688296 into swiftlang:main Jun 23, 2022
rctcwyvrn added a commit to rctcwyvrn/swift-experimental-string-processing that referenced this pull request Jun 30, 2022
@rctcwyvrn
Make the output of --compare nicer (swiftlang#512)
e1c9056 
- Space out the names properly instead of relying on tabs
- Add a decimal point to the percentage
- Filter out NS benchmarks from the comparison
- Sort comparisons by amount of improvement/regression
  (by s, not % beceause we have lots of variance + low runtime benchmarks)
@rctcwyvrn rctcwyvrn mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rctcwyvrn @milseman