Internalize _CharacterClassModel
#578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the DSL -> _CharacterClassModel conversion, and _CharacterClassModel's custom character class matching logic, none of which is being used.
`makeDSLTreeCharacterClass` was the last API that required it to be public. Remove it, and replace it with some static members on `_AST.Atom`.
|
@swift-ci please test |
milseman
approved these changes
Jul 14, 2022
| @@ -740,6 +740,32 @@ extension DSLTree { | |||
| @_spi(RegexBuilder) | |||
| public struct Atom { | |||
| internal var ast: AST.Atom | |||
|
|
|||
| // FIXME: The below APIs should be removed once the DSL tree has been | |||
| // migrated to use proper DSL atoms for them. | |||
There was a problem hiding this comment.
Adding them as dedicated cases to DSLTree.Atom (or splitting out a new BuiltinCharacterClass type perhaps), and then getting the consumer logic working with them. It's probably not too effort, but I'm going to leave it as a follow up for now. I can file an issue to track it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rip out unused
_CharacterClassModelAPI and make it an internal type by removing the last use ofmakeDSLTreeCharacterClass.