Skip to content

[5.7] Fix API naming mismatches from proposals #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Jul 15, 2022

Explanation:
In the regex builder proposal, we proposed adding regex options directly on Regex vs. on RegexComponent. In addition to changing that, the Unicode proposal for string processing proposed using the names simple and default for Unicode word breaking level 1 and level 2 respectfully.

Scope:
This only affects client who are using the current, incorrect, API names as well as using options on RegexComponents.

Main Branch PR:
#575 and #576

Resolves:
rdar://97024624

Risk:
Low

Reviewed By:
@milseman

Testing:
Updated our current tests to use the new API names/altered them somewhat to reflect the options change on Regex.

@Azoy Azoy requested review from milseman and stephentyrone July 15, 2022 05:37
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Azoy Azoy added r5.7 5.7 Release Cherry Picks labels Jul 15, 2022
@Azoy Azoy merged commit e94ecea into swiftlang:swift/release/5.7 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r5.7 5.7 Release Cherry Picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants