Skip to content

Fix matching of backreferences in scalar mode #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

rctcwyvrn
Copy link
Contributor

.backreference always matched in grapheme semantic mode (using matchSeq() which calls match), making this test fail

    // Backreferences in scalar mode
    // In scalar mode the backreference should not match
    firstMatchTest(#"(.+)\1"#, input: "ée\u{301}", match: "ée\u{301}")
    firstMatchTest(#"(.+)\1"#, input: "ée\u{301}", match: nil, semanticLevel: .unicodeScalar)

Fixed this by adding a bit to the payload for back references to check if it was emitted in unicode scalar mode

@rctcwyvrn rctcwyvrn requested a review from milseman August 4, 2022 19:59
@rctcwyvrn
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rctcwyvrn rctcwyvrn merged commit ec7727b into swiftlang:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants