Skip to content

Fix misuse of XCTSkip() #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix misuse of XCTSkip() #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Tests/RegexBuilderTests/RegexDSLTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1846,8 +1846,7 @@ extension RegexDSLTests {

func testLabeledCaptures_labeledCapture() throws {
guard #available(macOS 13, *) else {
XCTSkip("Fix only exists on macOS 13")
return
throw XCTSkip("Fix only exists on macOS 13")
}
// The output type of a regex with a labeled capture is dropped.
let dslWithLabeledCapture = Regex {
Expand Down Expand Up @@ -1886,8 +1885,7 @@ extension RegexDSLTests {

func testLabeledCaptures_bothCapture() throws {
guard #available(macOS 13, *) else {
XCTSkip("Fix only exists on macOS 13")
return
throw XCTSkip("Fix only exists on macOS 13")
}
// Only the output type of a regex with a labeled capture is dropped,
// outputs of other regexes in the same DSL are concatenated.
Expand All @@ -1913,8 +1911,7 @@ extension RegexDSLTests {

func testLabeledCaptures_tooManyCapture() throws {
guard #available(macOS 13, *) else {
XCTSkip("Fix only exists on macOS 13")
return
throw XCTSkip("Fix only exists on macOS 13")
}
// The output type of a regex with too many captures is dropped.
// "Too many" means the left and right output types would add up to >= 10.
Expand Down