Reverse .break(.close) and .close for array and dict literals.
#119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous order created an issue where the `.break(.close)` was outside of the group. The result was that it was possible just for the closing delimiter for an array/dict could break off from the rest of the literal. The new order of tokens places the break inside of the group, so the `.break(.open)` before the literal includes the length of the array/dict elements and the closing delimiter.
allevato
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous order created an issue where the
.break(.close)was outside of the group. The result was that it was possible just for the closing delimiter for an array/dict could break off from the rest of the literal. The new order of tokens places the break inside of the group, so the.break(.open)before the literal includes the length of the array/dict elements and the closing delimiter.