URL(filePath: path, directoryHint: .notDirectory) should strip trailing slashes #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Windows failure is real, the trailing slashes are not being stripped because they're backslashes at that point in the code, will push a fix |
…strip trailing slashes
jrflat
force-pushed
the
file-path-not-directory
branch
from
ce098f7 to
203ac4c
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
jmschonfeld
approved these changes
Aug 19, 2024
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Oct 8, 2024
…strip trailing slashes (swiftlang#867)
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Oct 14, 2024
…strip trailing slashes (swiftlang#867)
jrflat
added a commit
that referenced
this pull request
Oct 14, 2024
* (133878310) URL.fileSystemPath should drop all trailing slashes (#852) * (133882014) URL(filePath: path, directoryHint: .notDirectory) should strip trailing slashes (#867) * (137129292) URL(filePath:) should not treat "~" as absolute (#961) * (137068266) URL.fileSystemPath should strip leading slash for Windows drive letters (#964) * (137287143) URL path extension APIs should strip trailing slashes (#965)
jrflat
added a commit
that referenced
this pull request
Oct 14, 2024
* (133878310) URL.fileSystemPath should drop all trailing slashes (#852) * (133882014) URL(filePath: path, directoryHint: .notDirectory) should strip trailing slashes (#867) * (137129292) URL(filePath:) should not treat "~" as absolute (#961) * (137068266) URL.fileSystemPath should strip leading slash for Windows drive letters (#964) * (137287143) URL path extension APIs should strip trailing slashes (#965)
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…strip trailing slashes (swiftlang#867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user supplies a
pathwith trailing slash(es) and hints that it's.notDirectory, we should take their word for it and strip all trailing slashes. While that user input is slightly contradictory, this was the behavior before the Swift URL implementation, and at least it maintains the following consistency for anypath: