Skip to content

Support initializing string with nonLossyASCII encoding #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

jmschonfeld
Copy link
Contributor

In Foundation.framework, initializing a String with .nonLossyASCII behaves the same way as .ascii, so this replicates the behavior for non-FOUNDATION_FRAMEWORK builds.

Resolves #929

@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld merged commit cfcf10a into swiftlang:main Sep 20, 2024
3 checks passed
@jmschonfeld jmschonfeld deleted the string-init-nonlossyascii branch September 20, 2024 21:32
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot instantiate String with Data with encoding nonLossyASCII
3 participants