Skip to content

Guard old behavior in URL tests #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Guard old behavior in URL tests #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions Tests/FoundationEssentialsTests/URLTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,22 +640,30 @@ final class URLTests : XCTestCase {
}

func testURLTildeFilePath() throws {
var url = URL(filePath: "~")
func urlIsAbsolute(_ url: URL) -> Bool {
if url.relativePath.utf8.first == ._slash {
return true
}
guard url.baseURL != nil else {
return false
}
#if !FOUNDATION_FRAMEWORK_NSURL
return url.path().utf8.first == ._slash
#else
return url.path.utf8.first == ._slash
#endif
}

// "~" must either be expanded to an absolute path or resolved against a base URL
XCTAssertTrue(
url.relativePath.utf8.first == ._slash || (url.baseURL != nil && url.path().utf8.first == ._slash)
)
var url = URL(filePath: "~")
XCTAssertTrue(urlIsAbsolute(url))

url = URL(filePath: "~", directoryHint: .isDirectory)
XCTAssertTrue(
url.relativePath.utf8.first == ._slash || (url.baseURL != nil && url.path().utf8.first == ._slash)
)
XCTAssertTrue(urlIsAbsolute(url))
XCTAssertEqual(url.path().utf8.last, ._slash)

url = URL(filePath: "~/")
XCTAssertTrue(
url.relativePath.utf8.first == ._slash || (url.baseURL != nil && url.path().utf8.first == ._slash)
)
XCTAssertTrue(urlIsAbsolute(url))
XCTAssertEqual(url.path().utf8.last, ._slash)
}

Expand All @@ -677,7 +685,12 @@ final class URLTests : XCTestCase {
XCTAssertEqual(url.path(), "/path.foo/")
url.append(path: "/////")
url.deletePathExtension()
#if !FOUNDATION_FRAMEWORK_NSURL
XCTAssertEqual(url.path(), "/path/")
#else
// Old behavior only searches the last empty component, so the extension isn't actually removed
XCTAssertEqual(url.path(), "/path.foo///")
#endif
}

func testURLComponentsPercentEncodedUnencodedProperties() throws {
Expand Down