Rename toolchain msi and cab files to include name of variant (asserts) #428
Conversation
|
This looks good to me, lets take this over #427 since it already contains that commit as well. I'll trigger a new PR run for this. |
|
https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5916/ is the run. Seems that the naming of the cabinets and MSIs is not entirely correct yet? @mhegazy mind taking a look at the output? |
There was a problem hiding this comment.
I think this looks fine, though I believe it will require changes on the CI side of things to handle the new filenames. CC @shahmishal
missed, ide.cab rename. apologies. last commit should fix that. |
|
@compnerd mind rerunning the smoke tests |
Follow up to #427. This mechanically applies the same changes to the rest of the toolchain msi's to have msi and cab name based on the variant they carry (i.e. asserts)
The
.wixprojmove to to variant specific folder, to make room for adding additional variants in the future. Also renaming the properties holding upgradcode and product name for consistency.This change should not have any functional impact.