feat(hero-anim): Add mobile hero animation logic. Misc cleanup relate… #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to hero animation.
jesseaborden
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
nkrambo
approved these changes
Jun 2, 2025
| // Skip to visible portion of animation when cropped on small screens | ||
| const { left, width } = animContainer.getClientRects()[0] | ||
| const offScreenDelta = Math.abs(left) / width | ||
| const initProgressVal = 0 + offScreenDelta |
There was a problem hiding this comment.
Can this be: const initProgressVal = offScreenDelta
There was a problem hiding this comment.
Ah you want to make sure it starts from 0
There was a problem hiding this comment.
That was what I was thinking, but looking at it more, I don't think it's necessary. I chucked it. Thanks for catching that 🙂
federicobucchi
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
On smaller viewports, the hero graphic is cropped offscreen. This could cause a perceived performance issue as the animation playing offscreen is effectively an animation delay. This PR mainly adds logic to move the animation to the visible portion of the graphic. Additionally, this adds some cleanup and comments.
Modifications:
Result:
Hero animation starts from the visible portion of the container.