Fix CMake build to explicitly pick up ar and ranlib from toolchain. #6721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake under various conditions will attempt to use `llvm-ar` and `llvm-ranlib` when it spots that we're building using `clang`, and while that works fine on Linux, it doesn't work so well on Darwin, leaving us with a link failure with a perplexing error message. The rest of the Swift build is resilient to this problem already, but the `bootstrap` script here doesn't pass the relevant options to CMake, so it's possible to end up with the build failing when trying to link `lib/libCYaml.a` after the build has mangled the static library with `llvm-ranlib`. rdar://112478653
al45tair
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci Please test |
MaxDesiatov
approved these changes
Jul 18, 2023
|
@swift-ci smoke test |
tomerd
approved these changes
Jul 18, 2023
|
@al45tair please create 5.9 cherry pick once this lands on main |
etcwilde
approved these changes
Jul 18, 2023
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jul 19, 2023
…ng"" This reverts a3dd8d6, which should be fixed by swiftlang/swift-package-manager#6721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake under various conditions will attempt to use
llvm-arandllvm-ranlibwhen it spots that we're building usingclang, and while that works fine on Linux, it doesn't work so well on Darwin, leaving us with a link failure with a perplexing error message.The rest of the Swift build is resilient to this problem already, but the
bootstrapscript here doesn't pass the relevant options to CMake, so it's possible to end up with the build failing when trying to linklib/libCYaml.aafter the build has mangled the static library withllvm-ranlib.rdar://112478653