Skip to content

Add command line flag to enable experimental features #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add command line flag to enable experimental features #8665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7ec83
Add command line flag to enable experimental features
suzannaratcliff May 13, 2025
2dfcbfc
Update command line name and type
suzannaratcliff May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/Commands/SwiftTestCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ struct TestEventStreamOptions: ParsableArguments {
@Option(name: .customLong("attachments-path"),
help: "Path where attachments should be written (Swift Testing only). This path must be an existing directory the current user can write to. If not specified, any attachments created during testing are discarded.")
var attachmentsPath: AbsolutePath?

/// Which testing experimental features should be enabled
@Option(name: .customLong("enable-experimental-testing-feature"),
help: .private)
var enableExperimentalFeatures: String?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this has changed to be a singular, rather than plural, setting, I think the value should be an Array of String to allow for more than one experimental testing feature flag to be passed. I don't recall how exactly you do that using ArgumentParser but I believe there's a way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, to allow someone to pass

--enable-experimental-testing-feature FeatureA --enable-experimental-testing-feature FeatureB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look

}

struct TestCommandOptions: ParsableArguments {
Expand Down