Swift Build: pass some additional settings needed for cross-compilation #8697
+82
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
jakepetroules
force-pushed
the
eng/PR-xcompilation-settings
branch
from
b76c9e2 to
5f7cc65
Compare
|
@swift-ci test |
|
@swift-ci test windows |
owenv
reviewed
May 20, 2025
| @@ -562,3 +593,41 @@ fileprivate extension SwiftBuild.SwiftBuildMessage.DiagnosticInfo.Location { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| fileprivate extension Triple { | |||
| var deploymentTargetSettingName: String? { | |||
There was a problem hiding this comment.
missing a case for visionOS?
There was a problem hiding this comment.
Yes, but the entire codebase is missing visionOS cases right now, I'll look at handling that separately.
owenv
approved these changes
May 20, 2025
jakepetroules
force-pushed
the
eng/PR-xcompilation-settings
branch
from
5f7cc65 to
dcd5f18
Compare
|
@swift-ci test |
|
@swift-ci test windows |
jakepetroules
added
cross-compilation
build system
|
@swift-ci test windows self hosted |
|
@swift-ci test windows |
|
@swift-ci test self-hosted windows |
|
@swift-ci test windows |
This patch ensures that the Swift Build SDK and platform name are set correctly for embedded Apple platforms (iOS, tvOS, watchOS) and Android, that the SDK variant is set correctly for Mac Catalyst, and that the deployment target version is correctly propagated from the `--triple` argument specified on the command line.
jakepetroules
force-pushed
the
eng/PR-xcompilation-settings
branch
from
dcd5f18 to
9b9a4eb
Compare
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that the Swift Build SDK and platform name are set correctly for embedded Apple platforms (iOS, tvOS, watchOS) and Android, that the SDK variant is set correctly for Mac Catalyst, and that the deployment target version is correctly propagated from the
--tripleargument specified on the command line.