If a node’s child has node_choices
or a collection has element_choices
use an enum to ensure there are only matching child nodes
#1010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #765 but rebased on
main
and with all tests passing.Previously, we relied on runtime checks to make sure only supported node types were used for a child with
node_choices
. If we explicitly model the set of supported nodes as an enum, we get compile-time safety.rdar://101200491