If a node’s child has node_choices or a collection has element_choices use an enum to ensure there are only matching child nodes
#1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/choices-enum
branch
from
0f0c420 to
80a0b40
Compare
|
@swift-ci Please test |
|
swiftlang/swift-stress-tester#206 @swift-ci Please test macOS |
…ices` use an enum to ensure there are only matching child nodes Previously, we relied on runtime checks to make sure only supported node types were used for a child with `node_choices`. If we explicitly model the set of supported nodes as an enum, we get compile-time safety. rdar://101200491 Co-authored-by: Rintaro Ishizaki <[email protected]>
ahoppen
force-pushed
the
ahoppen/choices-enum
branch
from
80a0b40 to
d3471fd
Compare
|
swiftlang/swift-stress-tester#206 @swift-ci Please test |
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Oct 24, 2022
That swift-syntax change switched many accessors that degraded to `Syntax` type to return enums of their possibilities instead. DO NOT MERGE this still has one failing test.
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Oct 25, 2022
That swift-syntax change switched many accessors that degraded to `Syntax` type to return enums of their possibilities instead.
allevato
added a commit
to swiftlang/swift-format
that referenced
this pull request
Oct 25, 2022
Fix swift-format after swiftlang/swift-syntax#1010.
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #765 but rebased on
mainand with all tests passing.Previously, we relied on runtime checks to make sure only supported node types were used for a child with
node_choices. If we explicitly model the set of supported nodes as an enum, we get compile-time safety.rdar://101200491