Skip to content

Add missing switch & for-each expression and while & if condition error #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2023
Merged

Add missing switch & for-each expression and while & if condition error #1429

merged 4 commits into from
Mar 25, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Mar 22, 2023

No description provided.

kimdv
kimdv commented Mar 22, 2023
View reviewed changes
kimdv
kimdv commented Mar 22, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch 2 times, most recently from 3f83de1 to 311180e Compare March 22, 2023 21:14
@kimdv kimdv requested a review from ahoppen March 22, 2023 21:14
kimdv
kimdv commented Mar 22, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch from 311180e to 94bda6f Compare March 22, 2023 21:16
ahoppen
ahoppen reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. If you want, you can do the same for if and else if

@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch from 94bda6f to 321f48d Compare March 23, 2023 08:43
@kimdv
Copy link
Contributor Author

kimdv commented Mar 23, 2023

Thanks. If you want, you can do the same for if and else if

Also added for and while loops

kimdv
kimdv commented Mar 23, 2023
View reviewed changes
ahoppen
ahoppen reviewed Mar 23, 2023
View reviewed changes
@kimdv kimdv changed the title Add missing switch expression error [WIP] Add missing switch & for-each expression and while & if condition error [WIP] Mar 24, 2023
@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch 3 times, most recently from 6a9b2d3 to 68b9edb Compare March 24, 2023 19:05
@kimdv kimdv marked this pull request as ready for review March 24, 2023 19:05
@kimdv kimdv requested a review from ahoppen March 24, 2023 19:05
@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch from 68b9edb to 20aa95e Compare March 24, 2023 19:24
ahoppen
ahoppen reviewed Mar 24, 2023
View reviewed changes
@kimdv kimdv changed the title Add missing switch & for-each expression and while & if condition error [WIP] Add missing switch & for-each expression and while & if condition error Mar 24, 2023
@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch from 20aa95e to f17b126 Compare March 24, 2023 20:01
@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch 2 times, most recently from 302eb35 to a5ca89f Compare March 24, 2023 20:12
@kimdv kimdv force-pushed the kimdv/add-missing-switch-expression-error branch from a5ca89f to 76b4d04 Compare March 24, 2023 20:18
@kimdv
Copy link
Contributor Author

kimdv commented Mar 24, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Mar 24, 2023

@swift-ci please test Windows

@kimdv kimdv merged commit cf2d4c6 into swiftlang:main Mar 25, 2023
@kimdv kimdv deleted the kimdv/add-missing-switch-expression-error branch March 25, 2023 06:10
ahoppen pushed a commit to ahoppen/swift-syntax that referenced this pull request Mar 31, 2023
@kimdv @ahoppen
Merge pull request swiftlang#1429 from kimdv/kimdv/add-missing-switch…
8fcb01f 
…-expression-error
@ahoppen ahoppen mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimdv @ahoppen