Make leading/trailing trivia required fields #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
DougGregor
approved these changes
Mar 31, 2023
ahoppen
approved these changes
Mar 31, 2023
|
@swift-ci please test |
kimdv
reviewed
Mar 31, 2023
bnbarham
added a commit
to bnbarham/swift
that referenced
this pull request
Mar 31, 2023
swiftlang/swift-syntax#1477 makes `leadingTrivia` and `trailingTrivia` non-optional.
|
@swift-ci please test |
bnbarham
added a commit
to bnbarham/swift
that referenced
this pull request
Mar 31, 2023
swiftlang/swift-syntax#1477 makes `leadingTrivia` and `trailingTrivia` non-optional.
Rather than having the possibility of `nil` trivia and requiring all clients to check every use, just return empty trivia when there are no nodes present.
|
swiftlang/swift#64814 @swift-ci please test |
bnbarham
added a commit
to bnbarham/swift
that referenced
this pull request
Apr 3, 2023
swiftlang/swift-syntax#1477 makes `leadingTrivia` and `trailingTrivia` non-optional. (cherry picked from commit 2ad8db4)
kishikawakatsumi
added a commit
to kishikawakatsumi/swift-power-assert
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having the possibility of
niltrivia and requiring all clients to check every use, just return empty trivia when there are no nodes present.