[Syntax] Workaround for 'cannot bypass resilience' warnings #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Mar 17, 2025
Sources/SwiftSyntax/Syntax.swift
Outdated
| private let mutex: PlatformMutex | ||
| /// | ||
| /// - Note: `UnsafeMutableRawPointer` + casting accessor is a workaround to silence the warning 'cannot bypass resilience'. | ||
| private let _mutex: UnsafeMutableRawPointer! |
There was a problem hiding this comment.
Why does this nave to be an IUO? Shouldn’t we be able to make this a UnsafeMutableRawPointer?
There was a problem hiding this comment.
We have platforms where it is actually nil (i.e !SWIFTSYNTAX_HAS_THREAD). I used IUO because the PlatformMutex.opaque type is UnsafeMutableRawPointer! (by default by ClangImporter)
There was a problem hiding this comment.
Oh, I see. Should we just make it a proper optional in that case?
There was a problem hiding this comment.
Okay, I don't see any drawbacks for using optional. Done
|
@swift-ci Please test |
`RawSyntaxArena` and `SyntaxDataaArena` have properties with types from `_SwiftSyntaxCShims` which is `@_implementationOnly` when compiling with '-enable-library-evolution`. But for `-allow-non-resilient-access` for the package cross module optimizations, they causes warnings: ``` warning: cannot bypass resilience due to member deserialization failure while attempting to access member 'mutex' of 'SyntaxDataArena' in module 'SwiftSyntax' from module 'SwiftSyntax' warning: cannot bypass resilience due to member deserialization failure while attempting to access member 'hasParent' of 'RawSyntaxArena' in module 'SwiftSyntax' from module 'SwiftSyntax' ``` and non-resilient-access are disabled for these types. To workaround that, use `UnsafeRawPointer` for those stored properties and use casting methods to access the actual types. Note the using computed properties were not enough to silience the warnings.
rintaro
force-pushed
the
arena-non-resilient-access
branch
from
40b82e4 to
31182de
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Linux |
|
swiftlang/swift-package-manager#8386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RawSyntaxArenaandSyntaxDataaArenahave properties with types from_SwiftSyntaxCShimswhich is@_implementationOnlywhen compiling with-enable-library-evolution.But for
-allow-non-resilient-accessfor the package cross module optimizations, they caused warnings in 6.1+ compilers:and non-resilient-access are disabled for these types.
To workaround that, use
UnsafeRawPointerfor those stored properties and use casting methods to access the actual types. Note the using computed properties were not enough to silience the warnings.