Always build SwiftSyntax as a static library #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/build-swiftsyntax-statically
branch
from
b465a05 to
200167a
Compare
|
Waiting for a toolchain build triggered in swiftlang/swift#37710 to check if/how much the toolchain size changes because of this change. |
ahoppen
force-pushed
the
pr/build-swiftsyntax-statically
branch
from
200167a to
9825393
Compare
ahoppen
changed the title
|
The toolchain size seems to even decrease slightly with this change because before this PR we were essentially shipping two copies of |
Instead of including `SwiftSyntax.dylib` and `SwiftSyntaxParser.dylib` in the toolchain, make all tools that depend on SwiftSyntax link against it statically. This simplifies the way SwiftSyntax is built and slightly reduces the toolchain size, because we only include on copy of SwiftSyntax (statically linked into `sk-stress-test`) instead of two copies (`SwiftSyntax.dylib` and `SwiftSyntaxParser.dylib`). rdar://83757810
ahoppen
force-pushed
the
pr/build-swiftsyntax-statically
branch
from
9825393 to
4dbd190
Compare
ahoppen
changed the title
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
ahoppen
changed the title
akyrtzi
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of including
SwiftSyntax.dylibandSwiftSyntaxParser.dylibin the toolchain, make all tools that depend on SwiftSyntax link against it statically. This simplifies the way SwiftSyntax is built and slightly reduces the toolchain size, because we only include on copy of SwiftSyntax (statically linked intosk-stress-test) instead of two copies (SwiftSyntax.dylibandSwiftSyntaxParser.dylib).rdar://83757810