[PkgConfig] Add checks for circular dependencies #184
Conversation
Dadoum
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
|
Could we add a test for this? |
|
I should be able add a test, but it seems that the tests are made for macOS, and tests are making my swift-test crashing on my Linux. |
That's a bit surprising, could you share some more information about the crash you're seeing? CI runs tests on both macOS and Ubuntu Linux at least. |
|
on arch the process get killed and there is no crash log or whatever. Can't get anything with lldb and then swift-test stops |
I'm not familiar with this test, but it looks as if it's specifically designed to test signals. That should be investigated, but could you locally mark that test as skipped while developing the unit test for this PR, just to make progress? If you have time, it would be great filing the unit test failure on |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
can you relaunch test please ? @abertelrud |
|
@swift-ci please test |
|
The linux error looks like an intermitted failure. Rerunning test. |
|
@swift-ci please test linux |
|
Looks like the tests have passed now, thanks for your contribution @Dadoum |
Some libraries form dependency cycles such as
freetypeandharfbuzzon Arch Linux. This PR tries to avoid cycles by tracking pkg-config packages dependencies and detecting two occurences of a same library in the same branch.