Fatal error in unimplemented cases of exec
#285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
abertelrud,
aciidgh,
friedbunny and
tomerd
as code owners
|
@swift-ci please test |
abertelrud
approved these changes
Jan 25, 2022
The `exec` function was missing an `#else` branch which prohibited compilation on some platforms, this adds a fatal error on platforms where we have no implementation.
neonichu
changed the title
execexec
|
@swift-ci please test |
|
cc @compnerd @jakepetroules which have been opening PRs in this area over the last couple of days |
jakepetroules
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
execfunction was missing an#elsebranch which prohibited compilation on some platforms, this adds a fatal error on platforms where we have no implementation.