TSCBasic: enable proper rendering on Windows #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the behaviour of rendering on Windows after a very long time. However, since `TERM` is not an environment variable on Windows, simply elide the check for that. This finally gives us proper rendering on Windows.
compnerd
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
This depends on swiftlang/swift-package-manager#4192 to get proper rendering. |
|
@swift-ci please test |
tomerd
approved these changes
Mar 4, 2022
|
I think that is part of the problem, I don't have a good way to test this in a test case. The behaviour is not something that is entirely in our control. It requires synchronization between a test application, OS, llbuild, and s-p-m. On this own this is just undoing the blanket "do not support rendering terminals". This was a workaround for the underlying problem which has now been resolved. |
neonichu
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the behaviour of rendering on Windows after a very long
time. However, since
TERMis not an environment variable on Windows,simply elide the check for that. This finally gives us proper rendering
on Windows.