[5.6] [TSCUtility] Added Armv5 support #306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemancda
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
neonichu
changed the title
|
@swift-ci test |
|
@colemancda How is this going to be used in 5.6? |
|
I've built a patched toolchain using this change https://github.com/MillerTechnologyPeru/swift/releases/tag/swift-5.6-RC1-ARMV5 This has a corresponding StdLib patch swiftlang/swift#42056 This code has already been merged into |
|
Also has a swift-driver patch that directly uses this swiftlang/swift-driver#1040, and the Swift Package Manager also uses this code. |
|
thanks @colemancda change control into release branches like 5.6 is managed quite tightly, and typically we only take bug fixes to handle regressions in the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported #296 for Swift 5.6 release.