[WIP] SIL: Add devirtualizer support for default witness methods #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
slavapestov
force-pushed
the
devirt-default-witness
branch
from
7b34128 to
44c17b8
Compare
|
@swift-ci Please test |
We ignore substitutions from the conformance, using the Self type substitution from the call site instead. The new SILFunctionType::getDefaultWitnessMethodProtocol() method is used to figure out what "shape" the Self substitutions need to take. This is cleaner than it was before the method was added, but is still a bit of a hack; more and more it appears that we need to stop thinking of witness_method as a separate calling convention, and design what @rjmccall described as "abstraction patterns for generic signatures" instead.
slavapestov
force-pushed
the
devirt-default-witness
branch
from
44c17b8 to
77b6969
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore substitutions from the conformance, using the Self type
substitution from the call site instead.
This is a bit of a hack; more and more it appears that we need to
stop thinking of witness_method as a separate calling convention,
and design what @rjmccall described as "abstraction patterns for
generic signatures" instead.