Skip to content

[CMakeLists] Remove unused SWIFT_INCLUDE_OUTPUT_INTDIR + comment out unnecessary logic #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2016
Merged

Conversation

practicalswift
Copy link
Contributor

SWIFT_INCLUDE_OUTPUT_INTDIR appears not to be unused (let me know if I am missing some indirect usage path :-)):

$ git grep SWIFT_INCLUDE_OUTPUT_INTDIR
$

@modocache
Copy link
Contributor

Thanks so much for this. Trimming down the build scripts is really helpful. Obsolete variables can lead people down rabbit holes--which happened to me just yesterday. 😃

@practicalswift
Copy link
Contributor Author

@modocache Actually it was your PR #1410 that made me look into unused CMakeLists variables :-)

I wrote a small script that tries to find unused variables. I've found 18 candidates for deletion (including the one reported in #1410 and the two covered by this PR).

However, I'm a bit unsure about some of them so I'd love to have someone familiar with cmake/the general build process look in to each case to see if I'm missing some dependency/indirect usage. What is the best way to proceed? Should I submit a PR marked "WIP" and have it reviewed?

@@ -1,8 +1,8 @@
add_subdirectory(vim)

if(SWIFT_INSTALL_TOOLS)
# if(SWIFT_INSTALL_TOOLS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete this code :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. If there is indeed something we can do better with regards to installing gyb, we should document that in a ticket on https://bugs.swift.org (along with much more detail than present here).

@gribozavr
Copy link
Contributor

This LGTM.

@practicalswift
Copy link
Contributor Author

@gribozavr Updated and rebased as per your request :-)

gribozavr added a commit that referenced this pull request Mar 1, 2016
[CMakeLists] Remove unused SWIFT_INCLUDE_OUTPUT_INTDIR + comment out unnecessary logic
@gribozavr gribozavr merged commit c814676 into swiftlang:master Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants