[stdlib] Enable lgamma for Android. #19862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android Bionic offers lgammaf_r and lgamma_r only if _GNU_SOURCE is provided. It also offers lgammal_r in API levels 23 and above, but that one will not be available until 128 bit floats are supported. The patch modifies the importer to use _GNU_SOURCE while importing Android headers and slighly modify a check that was avoding the function from being created for Android. This fixes the compilation of the tgmath test in Android.
compnerd
approved these changes
Oct 12, 2018
| @@ -292,8 +292,8 @@ public func ${bfunc}(_ lhs: ${T}, _ rhs: ${T}) -> ${T} { | |||
| % if T == 'Float80': | |||
| #if (arch(i386) || arch(x86_64)) && !os(Windows) | |||
| % else: | |||
| // lgamma not avaialable on Windows, apparently? | |||
| #if !os(Windows) && !os(Android) | |||
| // lgamma not available on Windows, apparently? | |||
There was a problem hiding this comment.
lol, not apparently, it is true, it is not. The Windows environment does not have C99 math support.
|
@swift-ci please test |
stephentyrone
approved these changes
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Bionic offers lgammaf_r and lgamma_r only if _GNU_SOURCE is
provided. It also offers lgammal_r in API levels 23 and above, but
that one will not be available until 128 bit floats are supported.
The patch modifies the importer to use _GNU_SOURCE while importing
Android headers and slighly modify a check that was avoding the
function from being created for Android.
This fixes the compilation of the tgmath test in Android.