[ClangImporter] Fall back to Swift class names when resolving @class #27921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher Rogers' (good) work in 49fd5ac caught places where the Swift compiler was allowing a @Class to resolve to a Swift class even if that class had a conflicting Objective-C name, or wasn't intended to be exposed to Objective-C at all. Unfortunately, this broke source compatibility in projects where people were relying on this. Restore that functionality, but only as a fallback; matching the Objective-C name is better than matching the Swift name. rdar://problem/56681046
|
@ChristopherRogers, I'd appreciate your review as well! @swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
@swift-ci Please smoke test Linux |
|
LGTM! It'd be nice if eventually the compiler could diagnose this so code could be fixed. |
|
In the "this class isn't exposed to Objective-C at all" I'm not even sure there's something to fix it to. The other case, definitely—it just needs to wait a version or two so that everyone can switch to the right thing. |
xymus
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChristopherRogers' (good) work in #27682 caught places where the Swift compiler was allowing a
@classto resolve to a Swift class even if that class had a conflicting Objective-C name, or wasn't intended to be exposed to Objective-C at all. Unfortunately, this broke source compatibility in projects where people were relying on this. Restore that functionality, but only as a fallback; matching the Objective-C name is better than matching the Swift name.rdar://problem/56681046