isInvalid() Is Finally Semantic #27922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please smoke test macOS platform |
slavapestov
approved these changes
Oct 29, 2019
|
@swift-ci Please Test Source Compatibility Release |
|
@swift-ci please smoke test |
|
Love 2 have my build ICE'd @swift-ci Please Test Source Compatibility Release |
|
@swift-ci Please Test Source Compatibility Release |
|
@swift-ci please test |
|
@swift-ci please clean test macOS platform |
|
@swift-ci Please Test Source Compatibility Release |
|
This finally passes and naturally there's a merge conflict... |
Now that setInvalid() is a semantic property, drop the explicit calls to reset the interface type. It is already ErrorType.
Patch up all the places that are making a syntactic judgement about the isInvalid() bit in a ValueDecl. They may continue to use that query, but most guard themselves on whether the interface type has been set.
|
@swift-ci please smoke test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isInvalid()bit is intended to be sync'd to the presence of anErrorTypein the interface type of aValueDecl(for a regularDecl, it's kinda higgledy-piggledy). Historically, this had to be handled in an ad-hoc manner and callers had to make sure to set both lest they leave invalid ASTs in an inconsistent state. We even went so far as to teach the constraint solver to reset the invalid bit when it was unwinding which meant we had to track every singleValueDecl.Instead, make this predicate ask for the interface type. The setter now handles setting the interface type as well. A lot of cleanup falls out of this one change:
!getInterfaceType() || isInvalid()dancesPossiblyInvalidDeclssetInvalid(); setInterfaceType(ErrorType::get())variable 'x' is not bound by any patternbecause we're actually invalidating the AST correctly!A few places had to be patched up to break the new cycles this introduces, but serendipitously the cycle breaker in
getUnopenedTypeOfReferenceappears to be unnecessary.