build: remove SWIFT_NEED_EXPLICIT_LIBDISPATCH (NFC)
#28338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
compnerd
force-pushed
the
explictly-explicit
branch
from
052cbfd to
be5e1a1
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
This flag was being used as an alias for whether or not the host is non-Darwin. Rather than adding custom checks for this, use the explicit check that CMake supports. This simplifies the logic and avoids the proliferation of custom variables which can become confusing for others who are not familiar with the custom build infrastructure.
compnerd
force-pushed
the
explictly-explicit
branch
from
be5e1a1 to
18570c7
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@compnerd – This change makes libdispatch now required on non-Darwin platforms when previously it was not required. When/where was this dependency change discussed? If it was not discussed, can we please revert this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was being used as an alias for whether or not the host is
non-Darwin. Rather than adding custom checks for this, use the explicit
check that CMake supports. This simplifies the logic and avoids the
proliferation of custom variables which can become confusing for others
who are not familiar with the custom build infrastructure.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.