Fix casts involving the 'Self' type #28401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
fix-cast-to-self
branch
from
653af6b to
28630a5
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
fix-cast-to-self
branch
from
28630a5 to
cbecd9c
Compare
The cast optimizer was too eager to fold casts where the source and target lowered types were the same, even though the formal types might be different. Move the classifyFeasibility() check to deal with this case. Also in dead code elimination we have to mark all operands of a cast branch instruction as live, not just the first operand, otherwise we miss the special 'type dependent' self metadata operand and replace it with 'undef'.
Fixes <https://bugs.swift.org/browse/SR-11818>, <rdar://problem/57369535>.
slavapestov
force-pushed
the
fix-cast-to-self
branch
from
cbecd9c to
c8da158
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.swift.org/browse/SR-11818, rdar://problem/57369535.