Skip to content

[test] OptionSetTest: fix elementary logic error #28755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Dec 12, 2019

As it turns out, if we move a mutating operation behind a conditional, then the effect of that mutation won't apply when the condition is false. 🤦‍♂🤦‍♀🤦‍♂🤦‍♀

rdar://57870367

@lorentey
Copy link
Member Author

@swift-ci smoke test

@lorentey
Copy link
Member Author

Hm; not sure what happened here:

13:14:03 Running Swift tests for: check-swift-validation-macosx-x86_64
13:14:03 /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
13:14:03 /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
13:14:03 Build step 'Execute shell' marked build as failure

@lorentey
Copy link
Member Author

@swift-ci smoke test macOS platform

@lorentey
Copy link
Member Author

13:16:53 Building remotely on macOS-66 (mac-pro) in workspace /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test
13:16:53 No credentials specified
13:16:53  > git rev-parse --is-inside-work-tree # timeout=10
13:16:53 ERROR: Workspace has a .git repository, but it appears to be corrupt.
13:16:53 hudson.plugins.git.GitException: Command "git rev-parse --is-inside-work-tree" returned status code 137:

@lorentey
Copy link
Member Author

@swift-ci smoke test macOS platform

@lorentey
Copy link
Member Author

13:23:56 Compiler killed by signal 9

@xedin
Copy link
Contributor

xedin commented Dec 13, 2019

@swift-ci smoke test macOS platform

@shahmishal shahmishal merged commit f5b9ed6 into swiftlang:master Dec 13, 2019
@lorentey lorentey deleted the OptionSet-remove-back-deployment branch December 13, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants