[NFC] Remove ModuleDecl::isClangModule in favor of isNonSwiftModule.

[mateioprea]

Fixes SR-13237. (https://bugs.swift.org/browse/SR-13237)

[mateioprea]

@varungandhi-apple can you help with reviewing this? Thanks

[CodaFi]

@swift-ci smoke test

[varungandhi-apple]

You could do an interactive rebase (drop the second commit, modify the first commit to update the header) and then force-push.

[CodaFi]

We can also squash-and-merge this for you.

[mateioprea]

@CodaFi @varungandhi-apple done 👍

[varungandhi-apple]

Thanks for the cleanup!

[varungandhi-apple]

@swift-ci please smoke test and merge

[varungandhi-apple]

@swift-ci please smoke test and merge

[CodaFi]

@swift-ci smoke test macOS

[mateioprea]

"master" branch was also failing yesterday. Should I rebase and run the smoke tests again?

[varungandhi-apple]

master seems fine. The Java exceptions are related to some Jenkins + GitHub voodoo, where it doesn't fetch things properly from GitHub or it fetches out-of-date stuff.

@swift-ci please smoke test macOS platform

[mateioprea]

Ok. Do we need to do something here then? Or we should trigger the tests until they pass?

[varungandhi-apple]

That usually doesn't happen so often. I'm seeing another test fail, let me ask around. If it keeps failing, it needs to be x-failed, doesn't make sense to keep triggering the tests repeatedly.

[varungandhi-apple]

This PR should fix the issue we hit here: swiftlang/llvm-project#1576

Let's wait to re-run tests until that gets merged.

[varungandhi-apple]

The LLVM PR swiftlang/llvm-project#1576 is going to take some time to get fixed because there is a more serious issue than just cherry-picking. We probably shouldn't stay blocked on that.

@swift-ci please smoke test macOS

[mateioprea]

I see the OS X tests are failing. Maybe we should wait for swiftlang/llvm-project#1576 or try to rebase and re-test?

[varungandhi-apple]

@swift-ci please smoke test macOS