Skip to content

[CSBindings] Don't attempt to rank unviable bindings #33220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 30, 2020

If a type variable doesn't have any "direct" bindings let's not
consider it as viable to be attempted next. Such type variables
are helps purely to accommodate transitive binding inference
for other members of subtype chain.

Resolves: rdar://problem/66234725

@xedin xedin requested a review from hborla July 30, 2020 23:27
@xedin
Copy link
Contributor Author

xedin commented Jul 30, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jul 30, 2020

@swift-ci please test source compatibility debug

If a type variable doesn't have any "direct" bindings let's not
consider it as viable to be attempted next. Such type variables
are helps purely to accommodate transitive binding inference
for other members of subtype chain.

Resolves: rdar://problem/66234725
@xedin
Copy link
Contributor Author

xedin commented Jul 30, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jul 30, 2020

@swift-ci please test source compatibility debug

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Jul 31, 2020

@swift-ci please test source compatibility debug

@xedin xedin merged commit a0426df into swiftlang:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants