Skip to content

[Python3] Find the matching Python interpreter for LLDB in its build dir #33235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2020
Merged

[Python3] Find the matching Python interpreter for LLDB in its build dir #33235

merged 1 commit into from
Aug 3, 2020

Conversation

JDevlieghere
Copy link
Contributor

Instead of trying to guess which Python interperter matches the Python
that LLDB was build against, rely on the interpreter being present in
the build directory for testing. This way the two will always be in
sync.

@JDevlieghere JDevlieghere requested review from shahmishal and tbkka July 31, 2020 20:46
@JDevlieghere
Copy link
Contributor Author

Depends on swiftlang/llvm-project/pull/1579

@JDevlieghere JDevlieghere mentioned this pull request Jul 31, 2020
Merged
tbkka
tbkka approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahmishal
Copy link
Member

swiftlang/llvm-project/pull/1579

@swift-ci test macOS

@shahmishal
Copy link
Member

swiftlang/llvm-project/pull/1579

@swift-ci test Ubuntu 20.04

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 64c4478b6916f8e25b8857083dbb88f0c9c0b243

@JDevlieghere
[Python3] Find the matching Python interpreter for LLDB in its build dir
68f6e0a 
Instead of trying to guess which Python interperter matches the Python
that LLDB was build against, rely on the interpreter being present in
the build directory for testing. This way the two will always be in
sync.
@JDevlieghere JDevlieghere force-pushed the use-lldb-python-interpreter branch from 64c4478 to 68f6e0a Compare July 31, 2020 22:19
@JDevlieghere
Copy link
Contributor Author

swiftlang/llvm-project/pull/1579

@swift-ci test macOS

@JDevlieghere
Copy link
Contributor Author

swiftlang/llvm-project/pull/1579

@swift-ci test Ubuntu 20.04

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 64c4478b6916f8e25b8857083dbb88f0c9c0b243

@swift-ci
Copy link
Contributor

Build failed
Swift Test Ubuntu 20.04 Platform
Git Sha - 64c4478b6916f8e25b8857083dbb88f0c9c0b243

@JDevlieghere
Copy link
Contributor Author

swiftlang/llvm-project/pull/1579

@swift-ci test macOS

@JDevlieghere
Copy link
Contributor Author

swiftlang/llvm-project/pull/1579

@swift-ci test Ubuntu 20.04

@shahmishal
Copy link
Member

This is the job for Ubuntu 20.04 - https://ci.swift.org/job/swift-pr-ubuntu-2004/4/console

@swift-ci
Copy link
Contributor

swift-ci commented Aug 1, 2020

Build failed
Swift Test Ubuntu 20.04 Platform
Git Sha - 68f6e0a

@JDevlieghere
Copy link
Contributor Author

swiftlang/llvm-project/pull/1579

@swift-ci test Ubuntu 20.04

@swift-ci
Copy link
Contributor

swift-ci commented Aug 1, 2020

Build failed
Swift Test Ubuntu 20.04 Platform
Git Sha - 68f6e0a

@shahmishal
Copy link
Member

@swift-ci test Ubuntu 20.04

@shahmishal
Copy link
Member

@swift-ci smoke test linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Aug 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - 64c4478b6916f8e25b8857083dbb88f0c9c0b243

@swift-ci
Copy link
Contributor

swift-ci commented Aug 2, 2020

Build failed
Swift Test Ubuntu 20.04 Platform
Git Sha - 68f6e0a

@JDevlieghere
Copy link
Contributor Author

@swift-ci test Ubuntu 20.04

@shahmishal
Copy link
Member

@swift-ci test linux platform

@JDevlieghere JDevlieghere merged commit 9a88b4e into swiftlang:master Aug 3, 2020
@JDevlieghere JDevlieghere deleted the use-lldb-python-interpreter branch August 3, 2020 22:07
@swift-ci
Copy link
Contributor

swift-ci commented Aug 4, 2020

Build failed
Swift Test Ubuntu 20.04 Platform
Git Sha - 68f6e0a

@JDevlieghere JDevlieghere mentioned this pull request Sep 24, 2020
Merged
JDevlieghere added a commit that referenced this pull request Sep 25, 2020
@JDevlieghere
[test] Re-enable linux-fatal-backtrace.swift
7a12847 
This was fixed by #33235

rdar://66389949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JDevlieghere @shahmishal @swift-ci @tbkka