[IRGen] Add main() to __swift5_entry. #33246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jckarter
reviewed
Aug 3, 2020
nate-chandler
force-pushed
the
emit-main-into-entry-segment
branch
2 times, most recently
from
a152626 to
63dcab6
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
nate-chandler
force-pushed
the
emit-main-into-entry-segment
branch
2 times, most recently
from
249bb4a to
bd84c07
Compare
nate-chandler
changed the title
nate-chandler
force-pushed
the
emit-main-into-entry-segment
branch
from
bd84c07 to
78d8b18
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
beccadax
approved these changes
Aug 3, 2020
nate-chandler
force-pushed
the
emit-main-into-entry-segment
branch
from
78d8b18 to
a87890a
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
|
Build failed |
|
Build failed |
nate-chandler
force-pushed
the
emit-main-into-entry-segment
branch
from
a87890a to
1210f4e
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test windows |
To enable lookup of the entry point, emit a pointer to that entry point into a new section; on MachO, the __swift5_entry section of the __TEXT segment. rdar://problem/66402358
nate-chandler
force-pushed
the
emit-main-into-entry-segment
branch
from
1210f4e to
28cc144
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test windows |
|
@swift-ci please test |
|
@swift-ci please test windows |
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Sep 2, 2020
In swiftlang#33246 among other changes, a CHECK referring to the size of _swift1_autolink_entries was changed from a regex-based expectation to a static value. This means on platforms with different link flags, this expectation fails but does not signify any real failure. Revert back to using a regex check for the length of this constant.
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Dec 11, 2020
In swiftlang#33246 among other changes, a CHECK referring to the size of _swift1_autolink_entries was changed from a regex-based expectation to a static value. This means on platforms with different link flags, this expectation fails but does not signify any real failure. Revert back to using a regex check for the length of this constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable lookup of the entry point, emit a pointer to that entry point into a new section; on MachO, the __swift5_entry section of the
__TEXTsegment.rdar://problem/66402358