DependenciesScanner: add implicitly imported modules to dependencies of Swift module interfaces #33264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test OS X platform |
nkcsgexi
force-pushed
the
onone-import-scanner
branch
from
8e2d4df to
6ce247d
Compare
|
@swift-ci please smoke test |
…of Swift module interfaces Some implicitly imported modules aren't printed in the textual interface file as explicit import, e.g. SwiftOnoneSupport. We should check implicit imports and add them to the dependency graph.
nkcsgexi
force-pushed
the
onone-import-scanner
branch
from
6ce247d to
f0cf220
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test OS X platform |
nkcsgexi
changed the title
|
This should properly fix the missing of SwiftOnoneSupport dependencies. cc: @artemcm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.