ASTScope: Stop sorting declarations by source range #34226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/llvm-project#1916 |
|
@swift-ci Please test source compatibility |
slavapestov
changed the title
Instead, let's rely on the existing source range assertions. They will fire if we add two nodes with overlapping or equal source ranges.
slavapestov
force-pushed
the
astscope-source-range-sorting
branch
from
fe223bb to
14620a3
Compare
|
swiftlang/llvm-project#1916 |
davidungar
approved these changes
Oct 8, 2020
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASTScope would filter out duplicate AST nodes and in some places, sort AST nodes by source range. Let's remove these and fix the underlying issues instead.
Builds upon #34207.