[lib/Parse] #58741 Do not suggest moving any or some to the beginning of a compositi…
#58742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on if the first type is already an existential or opaque type.
|
@swift-ci Please smoke test |
hborla
approved these changes
May 25, 2022
|
@swift-ci please smoke test |
|
⛵ |
|
@LucianoPAlmeida @moritzdietsche are either of you interested in cherry-picking this to the |
|
Sure, I can do it real quick =] |
|
Done :) |
moritzdietsche
restored the
fix-it-for-repeated-any-or-some-in-composition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on if the first type is already an existential or opaque type.
When
someoranyappear within a composition instead of at the beginning, the compiler suggests moving the keyword to the beginning. If either of the keywords already appear at the beginning of the composition, the code after the application of the fix-it will be syntactically incorrect.This change checks if
someoranyare already specified at the beginning of the composition and, if yes, simply suggests to remove the occurrence within the composition instead of moving it to the beginningResolves #58741.