[ShrinkBorrowScope] Adopt iterative dataflow. #58934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nate-chandler
force-pushed
the
rdar93186505
branch
from
4a2565b to
6876e2b
Compare
|
@swift-ci please test |
|
@swift-ci please benchmark |
nate-chandler
force-pushed
the
rdar93186505
branch
2 times, most recently
from
9a819f5 to
eff9294
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
rdar93186505
branch
2 times, most recently
from
0502a23 to
e568302
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
rdar93186505
branch
from
e568302 to
527c81c
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Adopt IterativeBackwardReachability. Enables hoisting end_borrow instructions over loops. That in turn enables hoisting destroy_values over those same loops. rdar://93186505
Avoids hoisting borrow scopes into unrelated access scopes which could introduce exclusivity violations. rdar://93060369
nate-chandler
force-pushed
the
rdar93186505
branch
from
527c81c to
3c7ad60
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt IterativeBackwardReachability and VisitBarrierAccessScopes. Enables hoisting borrow scopes over loops and avoiding hoisting borrow scopes into unrelated access scopes, respectively.
rdar://93186505
rdar://93060369